Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oauth-provider-go to custom-authentication.md #823

Closed
wants to merge 0 commits into from

Conversation

igk1972
Copy link

@igk1972 igk1972 commented Nov 16, 2017

Add netlify-cms-oauth-provider-go to docs/custom-authentication.md

EDIT: Closes #784.

@@ -6,6 +6,7 @@ Netlify CMS is meant to be platform agnostic, so we're always looking to expand
| Author | Supported Git hosts | Languages | Link |
|------------|---------------------------|-----------|---------------------------------------------------------------------|
| @vencax | GitHub, GitHub Enterprise | Node.js | [Repo](https://github.com/vencax/netlify-cms-github-oauth-provider) |
| @igk1972 | GitHub, GitHub Enterprise, Bitbacket, Gitlab | Go | [Repo](https://github.com/igk1972/netlify-cms-oauth-provider-go) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should add a note below this table saying that BitBucket and GitLab are not yet supported in the CMS? Or just let people figure that out on their own? @verythorough?

Copy link
Author

@igk1972 igk1972 Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little step to the future. Main keyword "...not yet...".

Edit line in docs/custom-authentication.md ? @tech4him1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it doesn't actually support those hosts, I'd say remove them for now.

@erquhart
Copy link
Contributor

@igk1972 I usually don't fix merge conflicts on PR's submitted on the fork's master branch, but it seemed harmless to update yours - and then I pushed our master to your fork instead of the updated version of your master 🙄. Re-opened with your changes under #845.

@igk1972
Copy link
Author

igk1972 commented Nov 27, 2017

Ok, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants