Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature (relation-widget) enable reordering for relation controls - closes 5684 #5873

Merged
merged 1 commit into from
Oct 21, 2021
Merged

feature (relation-widget) enable reordering for relation controls - closes 5684 #5873

merged 1 commit into from
Oct 21, 2021

Conversation

andipabst
Copy link
Contributor

@andipabst andipabst commented Oct 6, 2021

Summary
From issue #5684: Prepending a new value to a relation widget (which has multiple enabled) is very cumbersome. Since value re-ordering is not permitted, one must delete all existing values, add the new value followed by all pre-existing values.

This PR introduces ordering the elements in the relation widget like in the list widget.

Test plan
[

simplescreenrecorder.mp4

](url)

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • Code is formatted via running yarn format.
  • Tests are passing via running yarn test.
  • The status checks are successful (continuous integration). Those can be seen below.

@andipabst andipabst requested a review from a team October 6, 2021 22:04
@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 7, 2021
@andipabst
Copy link
Contributor Author

@erezrokah Could you please have a look? Is there anything I can improve?

@erezrokah
Copy link
Contributor

@erezrokah Could you please have a look? Is there anything I can improve?

Hi @andipabst, this is 100% on me being slow to review PRs. This one is on the top of my list now that we released #5780

Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this @andipabst 🚀

@erezrokah erezrokah merged commit a77a355 into decaporg:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants