Check possible identifier values for a valid one to use for {{slug}} #1757
Conversation
markphilpot
changed the title
|
Deploy preview for netlify-cms-www ready! Built with commit 8ebf010 |
|
Deploy preview for cms-demo ready! Built with commit 8ebf010 |
There was a problem hiding this comment.
Thanks for the PR!
One issue here is that, with this change, we no longer infer the identifier in a controlled manner. Eg., whichever identifier candidate happens to be first in your config.yml is the one that's used, rather than always using the same order of potential inferred fields. Details in the review.
| const fieldNames = collection.get('fields').map(field => field.get('name')); | ||
| return IDENTIFIER_FIELDS.find(id => fieldNames.find(name => name.toLowerCase().trim() === id)); |
There was a problem hiding this comment.
The only change needed here is doing a filter instead of a find, and returning the array of field names that occurs in both. We could greatly simplify this by using lodash.intersection. This allows the order of IDENTIFIER_FIELDS to dictate which field is used, otherwise this would be a breaking change.
|
#1543 provides the fix needed here. |
Fixes #1700
Summary
This change checks the entry values for
IDENTIFIER_FIELDSfor one that is valid (truthy) rather than using the first one found (title). I'm not sure this is how the community wants to solve this issue, but this works for my workflow.Was able to successfully create a post where
pathwas specified andtitlewas left empty (""). For reference, myslugfield in myconfig.ymlfile was"{{year}}-{{month}}-{{day}}-{{hour}}_{{minute}}_{{second}}"so it didn't contain {{slug}} to begin with.