Remove alert modal from localForage error case #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LMK if this works for you. |
|
Deploy preview for netlify-cms-www ready! Built with commit ed59ba5 |
|
Deploy preview for cms-demo ready! Built with commit ed59ba5 |
tech4him1
reviewed
Aug 26, 2018
| const message = `Unable to set localStorage key. Quota exceeded! Full disk?`; | ||
| return alert(`${message}\n\n${err}`); | ||
| const message = 'Unable to set localStorage key. Quota exceeded! Full disk?'; | ||
| console.log(message); |
There was a problem hiding this comment.
Let's do a console.warn here. Other than that, LGTM!
|
Cool thanks! And I assume you guys will have to merge it as well? |
|
Yes, once another maintainer reviews they will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1626
Remove alert modal from localForage error case
Test plan
yarn test