-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Implicit OAuth for GitLab #1314
Closed
tech4him1
wants to merge
28
commits into
gitlab-benaiah-rebased-onto-cursor-api
from
implicit-gitlab-auth
Closed
WIP: Implicit OAuth for GitLab #1314
tech4him1
wants to merge
28
commits into
gitlab-benaiah-rebased-onto-cursor-api
from
implicit-gitlab-auth
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make spinner appear while pages are requested Fix pagination alignment
them. This is not optimal, but it is how the GitHub implementation works and should be fixed later.
`hasWriteAccess` was not working in the case where permissions were granted on a single group-owned repo, instead of the entire group.
Deploy preview for netlify-cms-www ready! Built with commit ac08d0b |
Deploy preview for cms-demo ready! Built with commit ac08d0b |
03ecf19
to
0993a3b
Compare
12 tasks
cb0c93e
to
d7bedc9
Compare
The work from this branch has been squashed, rebased, and added to #1343 - thanks @tech4him1! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support implicit OAuth for logging in to the GitLab backend. Three settings in the backend config are available:
auth_type
(required):implicit
appid
(required): This will be the App (Client) ID from when you create the app in your GitLab profile.auth_url
(optional):https://gitlab.com/oauth/authorize
by default