Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implicit OAuth for GitLab #1314

Closed

Conversation

tech4him1
Copy link
Contributor

@tech4him1 tech4him1 commented Apr 24, 2018

Support implicit OAuth for logging in to the GitLab backend. Three settings in the backend config are available:

  • auth_type (required): implicit
  • appid (required): This will be the App (Client) ID from when you create the app in your GitLab profile.
  • auth_url (optional): https://gitlab.com/oauth/authorize by default

Benaiah and others added 28 commits April 19, 2018 15:47
Make spinner appear while pages are requested

Fix pagination alignment
them.

This is not optimal, but it is how the GitHub implementation works and
should be fixed later.
`hasWriteAccess` was not working in the case where permissions were
granted on a single group-owned repo, instead of the entire group.
@verythorough
Copy link
Contributor

Deploy preview for netlify-cms-www ready!

Built with commit ac08d0b

https://deploy-preview-1314--netlify-cms-www.netlify.com

@verythorough
Copy link
Contributor

Deploy preview for cms-demo ready!

Built with commit ac08d0b

https://deploy-preview-1314--cms-demo.netlify.com

@tech4him1 tech4him1 changed the base branch from master to gitlab-benaiah-rebased-onto-cursor-api April 24, 2018 02:30
@Benaiah Benaiah force-pushed the gitlab-benaiah-rebased-onto-cursor-api branch 4 times, most recently from 03ecf19 to 0993a3b Compare May 4, 2018 00:23
@Benaiah Benaiah mentioned this pull request May 7, 2018
12 tasks
@Benaiah Benaiah force-pushed the gitlab-benaiah-rebased-onto-cursor-api branch 4 times, most recently from cb0c93e to d7bedc9 Compare May 8, 2018 22:31
@Benaiah
Copy link
Contributor

Benaiah commented May 9, 2018

The work from this branch has been squashed, rebased, and added to #1343 - thanks @tech4him1!

@Benaiah Benaiah closed this May 9, 2018
@tech4him1 tech4him1 deleted the implicit-gitlab-auth branch May 9, 2018 18:07
@tech4him1 tech4him1 mentioned this pull request May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants