Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate uploading same asset name #783

Closed
talves opened this issue Nov 8, 2017 · 1 comment
Closed

Duplicate uploading same asset name #783

talves opened this issue Nov 8, 2017 · 1 comment
Labels
good first issue kind: bug
Milestone
1.0.0

Comments

@talves
Copy link
Collaborator

talves commented Nov 8, 2017

- This is a bug?

- What is the current behavior?

- Reproduce.
Open the media library ui and upload the same asset. A duplicate will show as in the picture above.

- What is the expected behavior?
Should only show one thumbnail per item

- Please mention your CMS, node.js, and operating system version.
Chrome Browser, et. al.
@talves talves mentioned this issue Nov 8, 2017
Merged
6 tasks
@erquhart
Copy link
Contributor

erquhart commented Nov 8, 2017

Since GitHub doesn't paginate, we could actually just check the array of images in memory for an image of the same name and remove the old one if it exists.

@erquhart erquhart added this to the 1.0.0 milestone Nov 27, 2017
@Dammmien Dammmien mentioned this issue Nov 29, 2017
Merged
erquhart pushed a commit that referenced this issue Dec 14, 2017
@Dammmien @erquhart
Fix #783 duplicate uploading same asset name (#853)
515dde1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue kind: bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@talves @erquhart