Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search, filter, and sortby on network members #150

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NoobTW
Copy link
Contributor

@NoobTW NoobTW commented Apr 16, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

lack of filter and sorting.

Issue Number: #45 #120

What is the new behavior?

Add filter, and sortby for network members like the official ZeroTier Central panel.
image

Does this introduce a breaking change?

  • Yes
  • No

Other information

I'm not familiar with material-ui, may need some refactor.

@NoobTW NoobTW requested a review from dec0dOS as a code owner April 16, 2023 05:45
@dec0dOS
Copy link
Owner

dec0dOS commented Apr 16, 2023

Hello, @NoobTW!

Thanks for your PR, but I have found some issues.

First of all, please run yarn lint before committing changes.
Seems to be something wrong with the NetworkMembers.jsx component after your changes.

Screenshot 2023-04-16 at 12 26 19

Please check your PR with different network dataset.

@drtech981
Copy link

Before this PR is merged, a couple of suggestions:

  1. There's no need for a Display Filter button. If the search box is populated, filtered results should be displayed. Otherwise all results are displayed. Can also add a CSS Crossmark to clear the Search Field.
  2. Sort should in addition to address and name, atleast include Peer Status and Last Seen.
  3. Again, coloumn titles can be made clickable (ascending>descending>disable sort cycle through as one clicks away) without adding yet another fied for sort reference.

Just some suggestions that might prevent future refactoring, and thanks @NoobTW for the PR!

@dec0dOS dec0dOS marked this pull request as draft April 21, 2023 12:43
@faymek
Copy link

faymek commented Jan 19, 2024

I hope this feature can be merged soon. Thank you all developers for your enthusiastic contributions.

@drno88
Copy link

drno88 commented Mar 11, 2024

UP
I hope this feature can be merged soon. Thank you all developers for your enthusiastic contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants