Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .babelrc (and similar) to .npmignore #381

Closed
yofreke opened this issue Dec 18, 2016 · 3 comments
Closed

Add .babelrc (and similar) to .npmignore #381

yofreke opened this issue Dec 18, 2016 · 3 comments

Comments

@yofreke
Copy link

yofreke commented Dec 18, 2016

I suddenly started getting build errors on the new version of debug. It's likely because babel-loader is seeing the .babelrc in node_modules/debug, which is then for some reason causing issues (because it cannot find presets relative to that babelrc).

While I plan on working around this using config, I do still have the question: Do these config files describing source structure belong in the npm package?

escwald pushed a commit to escwald/debug that referenced this issue Dec 19, 2016
…ed and which is not built with the module.
escwald pushed a commit to escwald/debug that referenced this issue Dec 19, 2016
…ed and which is not built with the module.
@escwald
Copy link
Contributor

escwald commented Dec 19, 2016

I had this issue as well, but it was "fixed" when I upgraded my npm with
npm install npm@latest -g

I have also added a pull request (#383) that should hide the .babelrc, but still make it work with the tests that use it.

@yamikuronue
Copy link
Contributor

yamikuronue commented Dec 20, 2016

My PR (#378) will fix this by removing Babel entirely.

@yofreke
Copy link
Author

yofreke commented Dec 21, 2016

Ty all

@yofreke yofreke closed this as completed Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants