Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong usage of chrome.storage.local #339

Closed
andreineculau opened this issue Dec 2, 2016 · 2 comments
Closed

wrong usage of chrome.storage.local #339

andreineculau opened this issue Dec 2, 2016 · 2 comments

Comments

@andreineculau
Copy link

andreineculau commented Dec 2, 2016 •
edited
Loading

debug sets the storage to chrome.storage.local if present, but then assumes that it can read it via .debug, which is incorrect.

It should be .get('debug', cb)
@thebigredgeek
Copy link
Contributor

@andreineculau can you put in a pull request?

andreineculau added a commit to andreineculau/debug that referenced this issue Dec 24, 2016
@andreineculau
fix debug-js#339 by normalize localStorage and browser.storage.local …
251f216 
…usage
andreineculau added a commit to andreineculau/debug that referenced this issue Dec 24, 2016
@andreineculau
fix debug-js#339 by normalize localStorage and browser.storage.local …
8acaa61 
…usage
andreineculau added a commit to andreineculau/debug that referenced this issue Dec 24, 2016
@andreineculau
fix debug-js#339 by normalizing localStorage and browser.storage.loca…
fe77c4b 
…l usage
andreineculau added a commit to andreineculau/debug that referenced this issue Jan 14, 2017
@andreineculau
fix debug-js#339 by normalizing localStorage and browser.storage.loca…
a54770f 
…l usage
andreineculau added a commit to andreineculau/debug that referenced this issue Jan 14, 2017
@andreineculau
fix debug-js#339 by normalizing localStorage and browser.storage.loca…
6e0d190 
…l usage
andreineculau added a commit to andreineculau/debug that referenced this issue Jan 14, 2017
@andreineculau
fix debug-js#339 by normalizing localStorage and browser.storage.loca…
0dac9b6 
…l usage
andreineculau added a commit to andreineculau/debug that referenced this issue Jan 15, 2017
@andreineculau
fix debug-js#339 by normalizing localStorage and browser.storage.loca…
1051435 
…l usage
andreineculau added a commit to andreineculau/debug that referenced this issue Jan 15, 2017
@andreineculau
fix debug-js#339 by normalizing localStorage and browser.storage.loca…
ead58f8 
…l usage
@Qix-
Copy link
Member

Qix- commented Jun 20, 2018

Closing as it's stale and I haven't seen problems with it get reported lately. Please let me know if this is not the case.

@Qix- Qix- closed this as completed Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andreineculau @Qix- @thebigredgeek