Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --generate-commit-name flag #282

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Add --generate-commit-name flag #282

merged 4 commits into from
Nov 22, 2024

Conversation

ProgHaj
Copy link
Collaborator

@ProgHaj ProgHaj commented Nov 20, 2024

No description provided.

@ProgHaj ProgHaj force-pushed the generate-commit-name-flag branch from c8c48af to 542dc97 Compare November 20, 2024 09:08
@ProgHaj ProgHaj force-pushed the generate-commit-name-flag branch from 542dc97 to 636856c Compare November 20, 2024 21:28
Copy link
Collaborator

@filip-debricked filip-debricked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (just update the variable names)!

internal/cmd/scan/scan.go Outdated Show resolved Hide resolved
internal/cmd/scan/scan.go Outdated Show resolved Hide resolved
internal/cmd/scan/scan.go Outdated Show resolved Hide resolved
internal/cmd/scan/scan.go Outdated Show resolved Hide resolved
@ProgHaj ProgHaj force-pushed the generate-commit-name-flag branch from 1f29b64 to 1d82877 Compare November 22, 2024 10:56
Copy link

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.01 (8.47 -> 8.46)

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 2 files(s) 🔥

View detailed results in CodeScene

🚩 Declining Code Health (highest to lowest):

  • Large Method scan.go: NewScanCmd 🔥

@filip-debricked filip-debricked self-requested a review November 22, 2024 11:09
Copy link
Collaborator

@filip-debricked filip-debricked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sweoggy sweoggy merged commit a3aafa8 into main Nov 22, 2024
18 checks passed
@sweoggy sweoggy deleted the generate-commit-name-flag branch November 22, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants