Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create push flow for Docker images #25

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Create push flow for Docker images #25

merged 1 commit into from
Dec 5, 2022

Conversation

viktigpetterr
Copy link
Contributor

No description provided.

@viktigpetterr viktigpetterr self-assigned this Dec 5, 2022
@ghost
Copy link

ghost commented Dec 5, 2022 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@viktigpetterr viktigpetterr changed the title Create push flow to DockerHub Create push flow for Docker images Dec 5, 2022
@viktigpetterr viktigpetterr force-pushed the publish-docker-cd branch 2 times, most recently from b20fc37 to b5fd569 Compare December 5, 2022 10:24
zozs
zozs requested changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@zozs zozs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just need to actually add tags for GHCR too :).

.github/workflows/docker.yml Show resolved Hide resolved
@viktigpetterr viktigpetterr requested a review from zozs December 5, 2022 12:23
zozs
zozs approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@zozs zozs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking mighty fine ✨

@viktigpetterr viktigpetterr merged commit 9a73515 into main Dec 5, 2022
@viktigpetterr viktigpetterr deleted the publish-docker-cd branch December 5, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zozs zozs zozs approved these changes

Assignees

@viktigpetterr viktigpetterr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viktigpetterr @zozs