Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn error enhancements #168

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Yarn error enhancements #168

merged 4 commits into from
Dec 19, 2023

Conversation

4ernovm
Copy link
Contributor

@4ernovm 4ernovm commented Dec 14, 2023

No description provided.

@4ernovm 4ernovm self-assigned this Dec 14, 2023
emilwareus
emilwareus approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@emilwareus emilwareus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
I added a case to be a bit more inclusive on missing dependency, and added the private-pacakge string to it.

filip-debricked
filip-debricked approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@filip-debricked filip-debricked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well done!

@4ernovm 4ernovm force-pushed the yarn-error-enhancements branch 2 times, most recently from 6bb97f9 to b42466d Compare December 19, 2023 08:54
@4ernovm 4ernovm force-pushed the yarn-error-enhancements branch from b42466d to d475642 Compare December 19, 2023 09:01
@github-actions GitHub Actions
Copy link

CodeScene PR Check

View detailed results in CodeScene
Code Health Quality Gates ✅ OK
Recommended Review Level Lightweight sanity check
Declining Code Health 0 findings(s) 🚩
Improving Code Health 0 findings(s) ✅
Affected Hotspots 0 files(s) 🔥

@sweoggy sweoggy merged commit 3db6bb9 into main Dec 19, 2023
19 checks passed
@sweoggy sweoggy deleted the yarn-error-enhancements branch December 19, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filip-debricked filip-debricked filip-debricked approved these changes

@emilwareus emilwareus emilwareus approved these changes

Assignees

@4ernovm 4ernovm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@4ernovm @emilwareus @filip-debricked @sweoggy