Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle error enhancements #165

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Gradle error enhancements #165

merged 4 commits into from
Dec 12, 2023

Conversation

4ernovm
Copy link
Contributor

@4ernovm 4ernovm commented Dec 11, 2023

No description provided.

@4ernovm 4ernovm self-assigned this Dec 11, 2023
@4ernovm 4ernovm changed the base branch from main to maven-error-enhancements December 11, 2023 18:04
filip-debricked
filip-debricked reviewed Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@filip-debricked filip-debricked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful documentation, great work! I would like to add the command to the IError and fix some small grammatical things, but overall looks good!

internal/resolution/pm/gradle/job.go Show resolved Hide resolved
internal/resolution/pm/gradle/job.go Show resolved Hide resolved
internal/resolution/pm/gradle/job.go Outdated Show resolved Hide resolved
internal/resolution/pm/gradle/job.go Outdated Show resolved Hide resolved
internal/resolution/job/errors.go Show resolved Hide resolved
filip-debricked
filip-debricked approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@filip-debricked filip-debricked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emilwareus emilwareus force-pushed the maven-error-enhancements branch from c6f48fc to 6c9c512 Compare December 12, 2023 14:19
@sweoggy sweoggy force-pushed the maven-error-enhancements branch from 43566d6 to d30f062 Compare December 12, 2023 15:30
Base automatically changed from maven-error-enhancements to main December 12, 2023 15:37
@sweoggy sweoggy force-pushed the gradle-error-enhancements branch from 57c6ebc to 9f595dd Compare December 12, 2023 15:40
@github-actions GitHub Actions
Copy link

CodeScene PR Check

View detailed results in CodeScene
Code Health Quality Gates ✅ OK
Recommended Review Level Lightweight sanity check
Declining Code Health 1 findings(s) 🚩
Improving Code Health 0 findings(s) ✅
Affected Hotspots 0 files(s) 🔥

🚩 Declining Code Health (highest to lowest):

  • Code Duplication job.go

@sweoggy sweoggy merged commit e4442ab into main Dec 12, 2023
19 checks passed
@sweoggy sweoggy deleted the gradle-error-enhancements branch December 12, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filip-debricked filip-debricked filip-debricked approved these changes

@sweoggy sweoggy Awaiting requested review from sweoggy

@emilwareus emilwareus Awaiting requested review from emilwareus

Assignees

@4ernovm 4ernovm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@4ernovm @filip-debricked @sweoggy @emilwareus