Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added firmware and modules for the wlan on RPi3 and ZeroW #470

Merged
merged 5 commits into from Aug 10, 2017
Merged

Added firmware and modules for the wlan on RPi3 and ZeroW #470

merged 5 commits into from Aug 10, 2017

Conversation

ghost
Copy link

@ghost ghost commented May 31, 2017

Request for comments: What needs to be changed to get pulled?

I got my hands on a RPi3 and after some tinkering, I got the installation over onboard WLAN to work.
While adding to much firmware to this installer probably wouldn't be a good idea, the Pi 3 and the Zero W seem to have the same chip (brcm43430), and supporting the official Raspberry chipsets would be reasonable.

However, the firmware package in Raspbian is too old, we need the one from raspberrypi.org. If that would be ok, I would add that as second download mirror (like this fork does: https://github.com/FooDeas/raspberrypi-ua-netinst ).

@ghost
Copy link
Author

ghost commented May 31, 2017

Works great with this PR: "Added automatic driver loading #469"

@diederikdehaas
Copy link
Member

diederikdehaas commented May 31, 2017

The idea behind the drivers_to_load parameter is that either we or the user makes a driver package/archive which will store the necessary modules needed for 'common' or user specific drivers needed for wireless devices and that parameter will tell the installer which drivers to load in the kernel so the device becomes usable.
I haven't looked at your other PR (yet) and that may be useful as well.
I do think that a reasonable case can be made to provide the firmware/drivers for the onboard wireless device of the RPi by default, but I haven't discussed this yet with my fellow contributors (or owners as we're now referred to here on GitHub). But as you noticed, the raspbian archives have outdated kernel/firmware :-(

@ghost ghost mentioned this pull request Jun 3, 2017
@Mausy5043
Copy link
Contributor

I would have no reservations to merge this.

* Added package firmware-brcm80211, removed hardcoded URL
* Replaced curl with wget for downloading files
* Coding style: added some quotes
@ghost ghost changed the title RFC: Added firmware and modules for the wlan on RPi3 and ZeroW Added firmware and modules for the wlan on RPi3 and ZeroW Jun 4, 2017
@@ -99,14 +111,14 @@ check_key() {
echo -n "Checking key file '${KEY_FILE}'... "

# check that there is only 1 public key in the key file
if [ ! $(gpg --homedir gnupg --keyid-format long --with-fingerprint --with-colons ${KEY_FILE} | grep ^pub: | wc -l) -eq 1 ] ; then
if [ "$(gpg --homedir gnupg --keyid-format long --with-fingerprint --with-colons "${KEY_FILE}" | grep ^pub: | wc -l)" -ne 1 ] ; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

update.sh Outdated
@@ -13,6 +13,9 @@ RASPBERRYPI_ARCHIVE_KEY_FILE_NAME="raspberrypi.gpg.key"
RASPBERRYPI_ARCHIVE_KEY_URL="${RASPBERRYPI_ARCHIVE_KEY_DIRECTORY}/${RASPBERRYPI_ARCHIVE_KEY_FILE_NAME}"
RASPBERRYPI_ARCHIVE_KEY_FINGERPRINT="CF8A1AF502A2AA2D763BAE7E82B129927FA3303E"

FIRMWARE_PACKAGE=${RASPBERRYPI_ARCHIVE_KEY_DIRECTORY}/pool/main/f/firmware-nonfree/firmware-brcm80211_0.43+rpi5_all.deb
Copy link
Member

@diederikdehaas diederikdehaas Jul 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a newer one, named firmware-brcm80211_20161130-3+rpi1_all.deb ... but that also has the downside of being a very specific file/version. (file sizes are the same, but the SHA256 checksum differs).
Don't have a solution (yet?), but wanted to note it before I forget it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this, but is it possible to make the version a wildcard?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, this was from the first commit. In the second it was replaced with a general mechanism.

Copy link
Contributor

@Mausy5043 Mausy5043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts that were caused by the latest merges

echo "FAILED !"
fi
fi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern here: Please look at lines 335-346, 605-612 & 1120-1127 -- which (also) supports WiFi dongles -- and confirm that these pieces of code will work together with your change.
I have no possibility to test this anymore :-(

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed.
This just installs another package with firmware blobs, which are used by the driver if needed.
The other sections install the program wpa_supplicant, which is needed as well. It handles the actual wireless connections in user mode for both on-board WiFi and dongles.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Thanks

@Mausy5043 Mausy5043 merged commit 7d8c41c into debian-pi:v1.1.x Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants