Modify macOS build files to only allow GUI launch on supported OS versions (and associated documentation change) #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated LSMinimumSystemVersion to prevent launch on unsupported macOS versions. Release notes for 2.3.0[1] state that macOS 10.12 is the minimum - this has not been verified in the code, however. [1] https://github.com/debauchee/barrier/releases/tag/v2.3.0
Updated OS support section, based in the discussion from issue debauchee#544. (Also cleaned up code formatting in FAQ section)
jgrisham
changed the title
|
Using Barrier on Win11, works the same as on 10, haven't noticed any differences. Maybe could be considered as supported OS. |
shymega
reviewed
Nov 3, 2021
|
Looks like we have a merge conflict. |
Added changes recommended by @shymega in debauchee#1260
Updated filename to begin with issue number (per the [twisted/towncrier](https://github.com/twisted/towncrier#readme) documentation).
I think I fixed that with a manual re-base of my patch branch with the current project master branch. (Having never done that manually before, there may be an extraneous commit in the history; perhaps that artifact won't import when this PR is merged.) |
|
This looks great! I'm happy to merge, and there's no conflicts with master, so let's go for it 💯 |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README.md and Info.plist file for macOS distribution to clarify OS version requirements (and to prevent launch crash report messages when launching Barrier on unsupported OS versions).
Merging this with the master branch should resolve issue #544.