Merge pull request #2 from dealnews/fix_urls_in_arrays_not_being_trimmed

Update values in the array when the values of the array are checked
dealnews · Jan 19, 2024 · f8d5d27 · f8d5d27
2 parents 4e29a24 + de3d3ac
commit f8d5d27
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/src/Constraint.php b/src/Constraint.php
@@ -185,8 +185,8 @@ public function filterPrimitive($value, string $type, array $constraint, array $
                 }
                 if (is_array($new_value) && !empty($constraint['constraint'])) {
                     try {
-                        foreach ($new_value as $nv) {
-                            $this->check($nv, $constraint['constraint']);
+                        foreach ($new_value as $k => $nv) {
+                            $new_value[$k] = $this->check($nv, $constraint['constraint']);
                         }
                     } catch (ConstraintException $e) {
                         $new_value   = null;

diff --git a/tests/Constraint/URLTest.php b/tests/Constraint/URLTest.php
@@ -33,6 +33,11 @@ public function constraintData() {
                 ['type' => 'url'],
                 'http://www.example.com/',
             ],
+            [
+                "http://www.example.com/  ",
+                ["type" => "url"],
+                "http://www.example.com/"
+            ],
             [
                 '    ',
                 ['type' => 'url'],

diff --git a/tests/ConstraintTest.php b/tests/ConstraintTest.php
@@ -276,6 +276,22 @@ public function successData() {
                 ],
                 [1,2,3]
             ],
+            [
+                [
+                    'https://www.example.com',
+                    'https://www.example.com  ',
+                ],
+                [
+                    'type'       => 'array',
+                    'constraint' => [
+                        'type' => 'url',
+                    ],
+                ],
+                [
+                    'https://www.example.com',
+                    'https://www.example.com',
+                ],
+            ],
             [
                 new \ArrayObject(),
                 [