Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus.Erlang: Fix Kernel.Utils.defdelegate usage for Elixir 1.14 #47

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

lanodan
Copy link
Contributor

@lanodan lanodan commented Aug 2, 2022

Elixir 1.14 changed Kernel.Utils.defdelegate/2 into Kernel.Utils.defdelegate_each/2

Elixir 1.14 changed Kernel.Utils.defdelegate/2 into Kernel.Utils.defdelegate_each/2
@ulissesalmeida
Copy link

Elixir v1.14 is officially released yesterday 🎉

This change would be way much more appreciate now 🙏🏽

@pierot
Copy link

pierot commented Oct 14, 2022

Can this be merged? Would be great, thanks!

@ulissesalmeida
Copy link

ulissesalmeida commented Oct 14, 2022

I don't know if it helps, but we're using this commit in production for several weeks, all good 👍🏽

@jrichocean
Copy link

Branch works for me as well and also hoping this can be merged, Thank you!

@gabrielpedepera
Copy link

Really interested in this too. By, chance do you have some estimation to merge and release it? Also if there's something that I can help with, just let me know.

@lanodan
Copy link
Contributor Author

lanodan commented Oct 21, 2022 via email

@alexandresw
Copy link

Could this PR be merged and released in a new version, please?

@imsoulfly
Copy link

Any news on this one? @deadtrickster maybe? Thx!

@mopp
Copy link

mopp commented Feb 14, 2023

@deadtrickster Hi! This PR is ready to merge.
We've waited for prometheus.ex to support the newest Elixir because monitoring is the most important part of our operation on the Elixir application in production. 🙏 🙏 🙏

@dustinrouillard
Copy link

Still not merged, fr :/

@Stratus3D
Copy link

I don't need this anymore - I've migrated to telemetry and telemetry_metrics_prometheus_core.

@mopp
Copy link

mopp commented Mar 29, 2023

@deadtrickster ping 🙏 🙏 🙏

eric-hostalery added a commit to jobteaser/prometheus.ex that referenced this pull request Mar 29, 2023
eric-hostalery added a commit to jobteaser/prometheus.ex that referenced this pull request Mar 29, 2023
@mopp
Copy link

mopp commented Jun 1, 2023

@deadtrickster @ikvmw please merge 🙏 🙏 🙏 🙏 🙏 🙏 🙏

@mopp
Copy link

mopp commented Jun 20, 2023

Elixir v1.15 is officially released yesterday 🎉

@gerbal
Copy link

gerbal commented Jul 4, 2023

@deadtrickster or @ikvmw Any update here?

@mopp
Copy link

mopp commented Jul 27, 2023

@deadtrickster We are waiting to merge 😭 😭 😭

@sorliem
Copy link

sorliem commented Oct 10, 2023

Bump on this, would be great to merge... 🙏

@epinault
Copy link

just to add more nagging, can this be merge? the community is going to hurt unless we start forking (which is not really a good place to be either) @deadtrickster please? can you help? who else is a project owner here?

@epinault
Copy link

for those who need, I updated also the deps and merge the fix here for now https://github.com/podium/prometheus.ex as another option

@deadtrickster deadtrickster merged commit 4c165f0 into deadtrickster:master Nov 16, 2023
@deadtrickster
Copy link
Owner

Sorry, I forgot 🤷‍♂️

@deadtrickster
Copy link
Owner

published package as well

@sorliem
Copy link

sorliem commented Nov 16, 2023

Thanks @deadtrickster !

@epinault
Copy link

thanks! @deadtrickster

@mopp
Copy link

mopp commented Nov 17, 2023

Thanks @deadtrickster !

@ulissesalmeida
Copy link

Thank you @deadtrickster

@ikavgo
Copy link

ikavgo commented Nov 17, 2023

😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.