Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable float NIF #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Portable float NIF #63

wants to merge 2 commits into from

Conversation

deadtrickster
Copy link
Owner

Replace #62 with more portable nif (courtesy of @benoitc)
(Extracted from https://gitlab.com/barrel-db/instrument, Gauge renamed to Value, instrument namespace to prometheus and target renamed from instrument_nif to prometheus_nif)

TODO

  • Limit number of iterations to prevent long-running or endless? CAS loops
  • Implement prometheus_value which tries to load this nif but fallbacks to gen_server (Windows)
  • Make compilation conditional via envvar (we don't need nif troubles with rabbitmq plugin-like use cases, where we don't instrument directly)
  • Adjust makefile targets + finally add rebar3_archive_plugin

Thanks @benoitc ;-)

@@ -1,4 +1,5 @@
sudo: false
dist: trusty
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default travis vms are very old (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant