Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI for this project #188

Open
wants to merge 111 commits into
base: master
Choose a base branch
from
Open

New UI for this project #188

wants to merge 111 commits into from

Conversation

zgs225
Copy link

@zgs225 zgs225 commented Sep 9, 2022

Hi, I'm working on a new UI for this project. It has several imporvements compares to the original UI. There's a website to preview, you can login in with demo/demo.

Improvement:

  • More beautiful
  • Mobile adapted
  • Display progress while uploading
  • Support upload multiple files
  • i18n supported

Screenshot:
Dingtalk_20220909155410

This branch is still in progress:

  • Documents
  • Users: list, create, update, delete
  • Code
  • Reset password
  • Login and logout
  • Download
  • View document
  • Rename document
  • Delete document
  • Create folder
  • Move documents
  • Delete folder
  • Rename folder

@zgs225
Copy link
Author

zgs225 commented Oct 10, 2022

The name has changed to rmfakecloud. The logo and favicon have been replaced by a new one too.
image

@ddvk
Copy link
Owner

ddvk commented Oct 20, 2022

So here are some things:
sync15 is not implemented
i don't like commit hooks
running the ui without the backend doesn't show any errors
clicking logout just hosws spinner (without a running backend)
the ui shows the main/documet page without the user being logged in
the build has to be fixed

@zgs225
Copy link
Author

zgs225 commented Oct 21, 2022

Thanks for your advice.

"the ui shows the main/documet page without the user being logged in", The user will redirect to login page if he is not authorized. I implement authentication by API invocation, it can't work without a running backend.

Could you describe more about sync15 implementation?

  • Add error page when without a running backend -> to fix 3, 4, 5
  • Fix build
  • Remove commit hooks
  • Implements sync15

@ddvk
Copy link
Owner

ddvk commented Oct 21, 2022

sync15 is a new version of the sync. it uses less bandwidth and allows for 2way sync.
i've been using it for some time and so far it has worked well, but was not the default.

there is a client implementation in rmapi.
I can add the api calls for creating folders and file move/rename

@zgs225
Copy link
Author

zgs225 commented Oct 28, 2022

Hi, @ddvk I have implemented the API for the sync15 backend except for the API for removing documentation. I want to implement it like the below:

Updates value of the property "delete" of blob documentation's metadata to true, then wait device to sync to remove documentation actually.

Can the implementation work properly? It's pleasure to have your advice.

@ddvk
Copy link
Owner

ddvk commented Oct 28, 2022

I also added the whole sync15 ui apis, let me see how we can merge them

@zgs225
Copy link
Author

zgs225 commented Oct 28, 2022

Ok, I add a new feature to the new UI, it now show different icon by document's type.


if dirty {
backend.Sync(uid)
log.Info(uiLogger, "document updated: id=", docid)

Check failure

Code scanning / CodeQL

Log entries created from user input

Log entry depends on a [user-provided value](1).
err := backend.DeleteDocument(uid, docId)

if err != nil {
log.Error("Delete document error: ", err)

Check failure

Code scanning / CodeQL

Log entries created from user input

Log entry depends on a [user-provided value](1).
doc, err := backend.CreateFolder(uid, req.Name, req.ParentID)

if err != nil {
log.Error(err)

Check failure

Code scanning / CodeQL

Log entries created from user input

Log entry depends on a [user-provided value](1).
@zgs225
Copy link
Author

zgs225 commented Oct 29, 2022

Hi, I do some efforts to fix make build and make all. By now, all review issues have been resolved. Would you like to do a second review?

These potential problems found by the github-code-scanning bot could be a false positive report, do these have to be fixed?

@dominikandreas
Copy link

I gave this new UI a try recently and just wanted to say: nice job. Haven't found any issues, uploading and organizing documents all worked smoothly. Great contribution, thanks @zgs225 !

@ddvk
Copy link
Owner

ddvk commented Nov 6, 2022

yes, the codeql are false positive.

@Gamer92000
Copy link

Hey! This UI looks nice.
But this didn't get the attention it deserved.
@zgs225, could you solve the conflicts that recently arose?
And @ddvk, would you mind reviewing this to merge it when ready?

@ddvk
Copy link
Owner

ddvk commented Dec 26, 2022

@Gamer92000 it's on my todo list. i'll even fix the conflict, but haven't had time

@Gamer92000
Copy link

Sounds good! 👍


Dann wünsche ich noch einen schönen Rest-Stephanstag :P

@nopper
Copy link

nopper commented Jul 9, 2023

Any update on this? I'd like to use this new shiny UI. It seems to be a great improvement in usability.

@zgs225
Copy link
Author

zgs225 commented Jul 11, 2023

Any update on this? I'd like to use this new shiny UI. It seems to be a great improvement in usability.

I appreciate your interest in the new UI. I want to assure you that I will make an effort to continue working on it, but I cannot guarantee a specific timeframe for its completion.

@feurer98 feurer98 mentioned this pull request Aug 17, 2023
@xendke
Copy link

xendke commented Sep 23, 2024

Hey everyone! I have a pull request against the fork to merge the latest changes and get this PR back up and running!

Mentioning here for awareness!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants