firmware_class: make sure fw requests contain a name

An empty firmware request name will trigger warnings when building device names. Make sure this is caught earlier and rejected. The warning was visible via the test_firmware.ko module interface: echo -ne "\x00" > /sys/devices/virtual/misc/test_firmware/trigger_request Reported-by: Sasha Levin <[email protected]> Signed-off-by: Kees Cook <[email protected]> Cc: [email protected] Tested-by: Sasha Levin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
ddstreet · Sep 24, 2014 · 471b095 · 471b095
1 parent 4157533
commit 471b095
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
@@ -1105,6 +1105,9 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
 	if (!firmware_p)
 		return -EINVAL;
 
+	if (!name || name[0] == '\0')
+		return -EINVAL;
+
 	ret = _request_firmware_prepare(&fw, name, device);
 	if (ret <= 0) /* error or already assigned */
 		goto out;