hwrng: core - correct error check of kthread_run call

The kthread_run() function can return two different error values but the hwrng core only checks for -ENOMEM. If the other error value -EINTR is returned it is assigned to hwrng_fill and later used on a kthread_stop() call which naturally crashes. Cc: [email protected] Signed-off-by: Martin Schwidefsky <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
ddstreet · Jul 28, 2015 · 17fb874 · 17fb874
1 parent f898c52
commit 17fb874
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
@@ -429,7 +429,7 @@ static int hwrng_fillfn(void *unused)
 static void start_khwrngd(void)
 {
 	hwrng_fill = kthread_run(hwrng_fillfn, NULL, "hwrng");
-	if (hwrng_fill == ERR_PTR(-ENOMEM)) {
+	if (IS_ERR(hwrng_fill)) {
 		pr_err("hwrng_fill thread creation failed");
 		hwrng_fill = NULL;
 	}