-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use v8-debug.h #50
Conversation
It seems that this header has been deprecated for some time. |
Hi @ddopson , could you please merge this as this can be a rather blocking issue with Node 10 ? |
Pretty please! |
Thanks for the contribution |
Would you like to be a maintainer for this package? I'm not doing much in
Node these days...
…On Wed, May 9, 2018 at 12:35 PM, Anton Whalley ***@***.***> wrote:
Thanks for the contribution
I’ll take a look later but it might stretch to the weekend before it’s
pushed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6d3-1f6Xgu3CENLtTM30vKASu_IY3Tks5twxrPgaJpZM4Tk3Pd>
.
|
Hi there ! Do you need any help to merge this ? |
@Djiit - I actually did! For a while, I had lost my GitHub password. Fixed now. Seriously, I don't even have a NodeJS environment installed, so if anybody wants to step up and be a more responsible maintainer for this package, it's a really low bar right now... |
I'd like to. First I need to *install* npm, and figure out which password I
used.
Bonus points for anybody who finds an automated build system. (seriously,
it should just auto-cut versions for every push to GitHub that passes
tests!)
…On Wed, May 16, 2018 at 11:31 AM, Chris Kim ***@***.***> wrote:
@No9 <https://github.com/No9> @ddopson <https://github.com/ddopson> Thank
you! Could you publish a new version to npm?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6d34AnLZuS26MMyS8x3BXn6KBtYxbyks5tzEZDgaJpZM4Tk3Pd>
.
|
Probably this?: https://docs.travis-ci.com/user/deployment/npm/
…On Wed, May 16, 2018 at 3:55 PM, Dave Dopson ***@***.***> wrote:
I'd like to. First I need to *install* npm, and figure out which password
I used.
Bonus points for anybody who finds an automated build system. (seriously,
it should just auto-cut versions for every push to GitHub that passes
tests!)
On Wed, May 16, 2018 at 11:31 AM, Chris Kim ***@***.***>
wrote:
> @No9 <https://github.com/No9> @ddopson <https://github.com/ddopson>
> Thank you! Could you publish a new version to npm?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#50 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA6d34AnLZuS26MMyS8x3BXn6KBtYxbyks5tzEZDgaJpZM4Tk3Pd>
> .
>
|
Is anyone willing to step up and work with me to get this module tested /
auto-deployed / become a maintainer?
…--- Dave
On Wed, May 16, 2018 at 3:55 PM, Dave Dopson ***@***.***> wrote:
Probably this?: https://docs.travis-ci.com/user/deployment/npm/
On Wed, May 16, 2018 at 3:55 PM, Dave Dopson ***@***.***> wrote:
> I'd like to. First I need to *install* npm, and figure out which password
> I used.
>
> Bonus points for anybody who finds an automated build system. (seriously,
> it should just auto-cut versions for every push to GitHub that passes
> tests!)
>
> On Wed, May 16, 2018 at 11:31 AM, Chris Kim ***@***.***>
> wrote:
>
>> @No9 <https://github.com/No9> @ddopson <https://github.com/ddopson>
>> Thank you! Could you publish a new version to npm?
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#50 (comment)>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AA6d34AnLZuS26MMyS8x3BXn6KBtYxbyks5tzEZDgaJpZM4Tk3Pd>
>> .
>>
>
>
|
Published as 1.0.1 as it's a backward compatible bug fix not new functionality |
No description provided.