Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use v8-debug.h #50

Merged
merged 1 commit into from
May 16, 2018
Merged

Don't use v8-debug.h #50

merged 1 commit into from
May 16, 2018

Conversation

tcolgate
Copy link
Contributor

No description provided.

@tcolgate
Copy link
Contributor Author

It seems that this header has been deprecated for some time.

@Djiit Djiit mentioned this pull request May 5, 2018
@Djiit
Copy link

Djiit commented May 5, 2018

Hi @ddopson , could you please merge this as this can be a rather blocking issue with Node 10 ?

@rojr
Copy link

rojr commented May 9, 2018

Pretty please!

@No9
Copy link
Collaborator

No9 commented May 9, 2018

Thanks for the contribution
I’ll take a look later but it might stretch to the weekend before it’s pushed

@ddopson
Copy link
Owner

ddopson commented May 9, 2018 via email

@Djiit
Copy link

Djiit commented May 15, 2018

Hi there ! Do you need any help to merge this ?

@ddopson ddopson merged commit 1b371ed into ddopson:master May 16, 2018
@ddopson
Copy link
Owner

ddopson commented May 16, 2018

@Djiit - I actually did! For a while, I had lost my GitHub password. Fixed now.

Seriously, I don't even have a NodeJS environment installed, so if anybody wants to step up and be a more responsible maintainer for this package, it's a really low bar right now...

@dy-dx
Copy link

dy-dx commented May 16, 2018

@No9 @ddopson Thank you! Could you publish a new version to npm?

@ddopson
Copy link
Owner

ddopson commented May 16, 2018 via email

@ddopson
Copy link
Owner

ddopson commented May 16, 2018 via email

@ddopson
Copy link
Owner

ddopson commented May 16, 2018 via email

@No9
Copy link
Collaborator

No9 commented May 17, 2018

Published as 1.0.1 as it's a backward compatible bug fix not new functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants