Fix ASCII property list parsing #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently parsing ASCII property lists fails immediately with the exception "unexpected EOF. malformed file"
|
@BradleyMarie thanks for the PR! I also see that someone else has a PR out #62 that fixes this but also makes the destSize adjustment on another line too. Could you confirm which is correct? |
|
Since the first read is reading into &listSize, my read of the code was that setting dummyCount to zero before parsing was the correct thing to do instead of replacing sizeof(listSize) with destSize. |
|
LGTM thanks! |
|
"someone else" was me. let it be) Closing my p.r. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently parsing ASCII property lists fails immediately with the exception "unexpected EOF. malformed file"
This fixes issue #59.