Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keepalive): Use keepalive-workflow@v2 to avoid dummy commit #28

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

julienloizelet
Copy link
Collaborator

The Issue

Fixes #27

How This PR Solves The Issue

Uses gautamkrishnar/keepalive-workflow@v2

Manual Testing Instructions

Untestable ( ? ).

On a personal project, I've tried the action with time_elapsed = 0 and the only thing we can see is a message we have to believe
: Kept repo active using the GitHub API ... :

Capture d’écran du 2024-03-14 17-51-29

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@julienloizelet julienloizelet requested a review from rfay March 14, 2024 09:00
@rfay
Copy link
Member

rfay commented Mar 14, 2024

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right thing to me. I haven't manually tested it. Thanks! It should be a major improvement.

@julienloizelet julienloizelet merged commit 6f45216 into ddev:main Mar 15, 2024
21 checks passed
@julienloizelet julienloizelet deleted the feat/keepalive-v2 branch September 30, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use v2 of keepalive-workflow
2 participants