-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs #5
Improve docs #5
Conversation
b61d94b
to
8304f7e
Compare
@rfay If you have time, could you give this the once over? |
Sure, it will probably be a day or two. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made several suggestions, but overall I didn't see real profiling data when I got it going. I only saw basic stuff, not the breakdowns I would expect showing where memory and CPU were used most, and the individual wall times.
It's worth including an xhgui
launcher custom command as well so people don't have to go do ddev describe
to find the port. And mention in the README that the port will be displayed in ddev describe
.
Co-authored-by: Randy Fay <[email protected]>
69117b3
to
7646914
Compare
Co-authored-by: Randy Fay <[email protected]>
Co-authored-by: Randy Fay <[email protected]>
Co-authored-by: Randy Fay <[email protected]>
4e5edba
to
262ee18
Compare
Thanks for showing me where to click, I clicked on the run, but not on the method. It's probably a good thing to add to the README? Or perhaps that's just the job of the upstream docs. |
The first time I got data into xhgui, I too was "underwhelmed"; it was pretty but where was all the good data? |
f1324fe
to
f321f43
Compare
Snuck in the helper command, |
Test with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, thanks! Now that I know where to click.
- I note that the volume for the mongo stuff (ddev-d10_xhgui-mongo) doesn't get deleted when the add-on is removed (but it would on ddev delete I think). That might be a thing to do in a follow-up.
- I am not sure why this uses its own mongo instead of depending on ddev-mongo, but ok...
- For the xhprof_prepend.php, we just have to get our heads together and think about how to handle it.
Awesome work, huge step forward.
3f232fc
to
7cce4d4
Compare
No description provided.