Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve readme #21

Merged
merged 1 commit into from
Nov 8, 2023
Merged

improve readme #21

merged 1 commit into from
Nov 8, 2023

Conversation

Morgy93
Copy link
Contributor

@Morgy93 Morgy93 commented Nov 7, 2023

The Issue

  • The readme has two sections "Configuration" and "Connection" that can be merged.
  • The "Memory Limit" section uses the legacy approach for editing configuration.

How This PR Solves The Issue

  • The Configuration and Connection section are merged.
  • The "Memory Limit" section uses the new config overwriting approach.

Manual Testing Instructions

Read the new readme sections and try to follow the things it provides.

Automated Testing Overview

Not possible for readme. I thought about adding memory limit checks but did not see much value.

Related Issue Link(s)

No related issues.

Release/Deployment Notes

Nothing needs to be done.

@rfay rfay requested a review from AronNovak November 7, 2023 21:28
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an improvement to me, thanks. We'll let @AronNovak pipe up here. Let's not forget to do a release to get your new image version in there.

@AronNovak AronNovak merged commit 77550ac into ddev:main Nov 8, 2023
@Morgy93 Morgy93 deleted the improve-readme branch November 8, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants