Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for WS client to publish MQTT messages to topics #16

Merged
merged 26 commits into from
Oct 24, 2023

Conversation

ddellacosta
Copy link
Owner

@ddellacosta ddellacosta commented Sep 22, 2023

2023-10-24_10-46

This should probably have been three separate PRs, especially considering the size, although ~1/3 of the lines added in this PR are auto-generated boilerplate in ui/package-lock.json.

In any case, here are the main chunks of functionality introduced, along with pointers and context for the most important pieces of each:

Final addendum: a bunch of Haskell dependencies got bumped too. I'm embarrassed to say I think this was a byproduct of nix tweaks when I updated spago, but I'm not sure 😅 ...on the other hand, I was finally able to bump the tls library to version 1.6.0, which removes SSLv3 support, which is nice.

P.S. it should go without saying that, because I'm the only one who reviewed this, there are almost definitely things I've missed.

@@ -157,7 +157,7 @@ mkRunAutomation filepath = \_broadcastChan -> do

loadScript :: FilePath -> FilePath -> Lua.LuaE Lua.Exception Lua.Status
loadScript luaScriptPath' filepath =
Lua.loadfile $ luaScriptPath' <> filepath <> ".lua"
Lua.loadfile . Just $ luaScriptPath' <> filepath <> ".lua"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy-ps.purs-tidy
pkgs.nodejs_20
pkgs.purescript
pkgs.nodejs_18
Copy link
Owner Author

@ddellacosta ddellacosta Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses an issue with GlobalRegistrator in Happy Dom (via elmish-testing-library), although I'm leveraging the fact that whatever is at 18 in nix is lower than 18.18.2, apparently >= is problematic

@ddellacosta ddellacosta marked this pull request as ready for review October 24, 2023 14:27
@ddellacosta ddellacosta merged commit 6e2d1ef into main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant