Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix GoReleaser config and option for GoReleaser v2 #290

Merged
merged 1 commit into from
Aug 24, 2024
Merged

chore: fix GoReleaser config and option for GoReleaser v2 #290

merged 1 commit into from
Aug 24, 2024

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Aug 24, 2024

The release workflow failed due to the breaking change of GoReleaser v2.

https://github.com/ddddddO/gtree/actions/runs/10540466053/job/29205156183#step:4:20

  ⨯ command failed                                   error=unknown flag: --rm-dist

--rm-dist was deleted.

https://github.com/ddddddO/gtree/releases/tag/v1.10.11

Releasing assets failed.

image

Test

$ goreleaser check
  • checking                                 path=.goreleaser.yml
  • 1 configuration file(s) validated
  • thanks for using goreleaser!
$ goreleaser release --snapshot
  • skipping announce, publish and validate...
  • loading environment variables
  • getting and validating git state
    • git state                                      commit=f4807001e6b4abf1ce018e6e7cc58462f48f5a7e branch=chore-goreleaser-v2 current_tag=v1.10.11 previous_tag=v1.10.10 dirty=false
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • snapshotting
    • building snapshot...                           version=1.10.11-SNAPSHOT-f480700
  • running before hooks
    • running                                        hook=go mod tidy
  • ensuring distribution directory
  • setting up metadata
  • writing release metadata
  • loading go mod information
  • build prerequisites
  • building binaries
    • building                                       binary=dist/gtree_windows_amd64_v1/gtree.exe
    • building                                       binary=dist/gtree_darwin_amd64_v1/gtree
    • building                                       binary=dist/gtree_windows_arm64/gtree.exe
    • building                                       binary=dist/gtree_darwin_arm64/gtree
    • building                                       binary=dist/gtree-linux_linux_386/gtree
    • building                                       binary=dist/gtree_windows_386/gtree.exe
    • building                                       binary=dist/gtree-linux_linux_amd64_v1/gtree
    • building                                       binary=dist/gtree-linux_linux_arm64/gtree
  • archives
    • creating                                       archive=dist/gtree_Windows_i386.zip
    • creating                                       archive=dist/gtree_Windows_x86_64.zip
    • creating                                       archive=dist/gtree_Darwin_arm64.tar.gz
    • creating                                       archive=dist/gtree_Linux_i386.tar.gz
    • creating                                       archive=dist/gtree_Darwin_x86_64.tar.gz
    • creating                                       archive=dist/gtree_Linux_arm64.tar.gz
    • creating                                       archive=dist/gtree_Windows_arm64.zip
    • creating                                       archive=dist/gtree_Linux_x86_64.tar.gz
  • linux packages
    • creating                                       package=gtree format=apk arch=arm64 file=dist/gtree_1.10.11-SNAPSHOT-f480700-1_arm64.apk
    • creating                                       package=gtree format=deb arch=arm64 file=dist/gtree_1.10.11-SNAPSHOT-f480700-1_arm64.deb
    • creating                                       package=gtree format=deb arch=amd64v1 file=dist/gtree_1.10.11-SNAPSHOT-f480700-1_amd64.deb
    • creating                                       package=gtree format=rpm arch=386 file=dist/gtree_1.10.11-SNAPSHOT-f480700-1_386.rpm
    • creating                                       package=gtree format=deb arch=386 file=dist/gtree_1.10.11-SNAPSHOT-f480700-1_386.deb
    • creating                                       package=gtree format=rpm arch=arm64 file=dist/gtree_1.10.11-SNAPSHOT-f480700-1_arm64.rpm
    • creating                                       package=gtree format=rpm arch=amd64v1 file=dist/gtree_1.10.11-SNAPSHOT-f480700-1_amd64.rpm
    • creating                                       package=gtree format=apk arch=386 file=dist/gtree_1.10.11-SNAPSHOT-f480700-1_386.apk
    • creating                                       package=gtree format=apk arch=amd64v1 file=dist/gtree_1.10.11-SNAPSHOT-f480700-1_amd64.apk
  • calculating checksums
  • homebrew tap formula
    • guessing install                               install=[bin.install "gtree"]
    • guessing install                               install=[bin.install "gtree"]
    • guessing install                               install=[bin.install "gtree"]
    • guessing install                               install=[bin.install "gtree"]
    • writing                                        formula=dist/homebrew/Formula/gtree.rb
  • scoop manifests
    • writing                                        manifest=dist/scoop/gtree.json
  • writing artifacts metadata
  • release succeeded after 10s
  • thanks for using goreleaser!

@ddddddO
Copy link
Owner

ddddddO commented Aug 24, 2024

@suzuki-shunsuke
I didn't realize the execution was failing. Thanks also for fixing the config file!
(First non-Me commit on gtree that I'm very happy about! 😆)

@ddddddO ddddddO merged commit 06662f5 into ddddddO:master Aug 24, 2024
3 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the chore-goreleaser-v2 branch August 24, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants