Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slicing logic #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions xrange.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,19 +101,20 @@ def __getitem_slice(self, slce):
"""Return an xrange which represents the requested slce
of the sequence represented by this xrange.
"""
start, stop, step = slce.start, slce.stop, slce.step
if step == 0:
start, stop, index_step = slce.start, slce.stop, slce.step
if index_step == 0:
raise ValueError('slice step cannot be 0')

start = start or self._start
stop = stop or self._stop
step = (index_step or 1) * self._step
if start < 0:
start = max(0, start + self._len)
if stop < 0:
stop = max(start, stop + self._len)

if step is None or step > 0:
return xrange(start, stop, step or 1)
if step > 0:
return xrange(start, stop, step)
else:
rv = reversed(self)
rv._step = step
Expand Down