This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Sync dcos-launch with latest acs-engine updates #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ionutbalutoiu thanks. I'll have to get our acs-engine integration test passing with this PR before I can merge |
|
@ionutbalutoiu I pushed a fix to master branch. Please rebase this PR on master and I'll re-run the integration test. It will most likely pass |
Since the bootstrap node support in acs-engine (Azure/acs-engine#2825), these parameters are not needed anymore.
ionutbalutoiu
force-pushed
the
acs-engine-updates
branch
from
57d578a to
9b67612
Compare
|
@cprovencher, done the master rebase. |
sschneid
approved these changes
May 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the bootstrap node support in acs-engine (Azure/acs-engine#2825), these parameters are not needed anymore.