Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update probot to v7 #80

Merged
merged 3 commits into from
Jul 13, 2018
Merged

update probot to v7 #80

merged 3 commits into from
Jul 13, 2018

Conversation

hiimbex
Copy link
Contributor

@hiimbex hiimbex commented Jul 9, 2018

Breaking these changes out from #79.

I still can't quite figure out why this test is failing.

@hiimbex hiimbex requested a review from bkeepers July 9, 2018 16:26
hiimbex and others added 3 commits July 12, 2018 21:46
@hiimbex @bkeepers
update probot to v7
c253083 
Signed-off-by: Brandon Keepers <[email protected]>
@bkeepers
Use Probot instead of Application directly
ac76d46 
Signed-off-by: Brandon Keepers <[email protected]>
@bkeepers
Relax version requirements
c92ef38 
Signed-off-by: Brandon Keepers <[email protected]>
bkeepers
bkeepers approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@bkeepers bkeepers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some changes to get the tests working again (and added the DCO signoff on all the commits :trollface:)

@hiimbex
Copy link
Contributor Author

hiimbex commented Jul 13, 2018

and added the DCO signoff on all the commits :trollface:

Are you trying to credit yourself for my commit? That is messed up :trollface:

@hiimbex hiimbex merged commit 197e8fd into master Jul 13, 2018
@hiimbex hiimbex deleted the v7 branch July 13, 2018 03:14
@bkeepers
Copy link
Contributor

Are you trying to credit yourself for my commit?

Event worse: I'm trying to claim that I have the rights to submit your commit to this repository! 😁

@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkeepers bkeepers bkeepers approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiimbex @bkeepers