Skip to content

Commit

Permalink
add clarification of what legal effect --signoff is supposed to even …
Browse files Browse the repository at this point in the history
…have

Fix: #106

Signed-off-by: d3fault <[email protected]>
  • Loading branch information
d3fault committed Oct 3, 2021
1 parent 018d78c commit a10130b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,9 @@ module.exports = ({ app }) => {
}

function handleOneCommit (pr, dcoFailed) {
return `You only have one commit incorrectly signed off! To fix, first ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally). Next, head to your local branch and run: \n\`\`\`bash\ngit commit --amend --no-edit --signoff\n\`\`\`\nNow your commits will have your sign off. Next run \n\`\`\`bash\ngit push --force-with-lease origin ${pr.head.ref}\n\`\`\``
return `You only have one commit incorrectly signed off! Signing off the commit certifies that the committer has the rights to submit this work under this project's license and agrees to the [Developer Certificate of Origin](https://developercertificate.org), either version 1.1 of the Developer Certificate of Origin, or (at your option) any later version. To fix, first ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally). Next, head to your local branch and run: \n\`\`\`bash\ngit commit --amend --no-edit --signoff\n\`\`\`\nNow your commits will have your sign off. Next run \n\`\`\`bash\ngit push --force-with-lease origin ${pr.head.ref}\n\`\`\``
}

function handleMultipleCommits (pr, commitLength, dcoFailed) {
return `You have ${dcoFailed.length} commits incorrectly signed off. To fix, first ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally). Next, head to your local branch and run: \n\`\`\`bash\ngit rebase HEAD~${commitLength} --signoff\n\`\`\`\n Now your commits will have your sign off. Next run \n\`\`\`bash\ngit push --force-with-lease origin ${pr.head.ref}\n\`\`\``
return `You have ${dcoFailed.length} commits incorrectly signed off. Signing off the commit certifies that the committer has the rights to submit this work under this project's license and agrees to the [Developer Certificate of Origin](https://developercertificate.org), either version 1.1 of the Developer Certificate of Origin, or (at your option) any later version. To fix, first ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally). Next, head to your local branch and run: \n\`\`\`bash\ngit rebase HEAD~${commitLength} --signoff\n\`\`\`\n Now your commits will have your sign off. Next run \n\`\`\`bash\ngit push --force-with-lease origin ${pr.head.ref}\n\`\`\``
}

0 comments on commit a10130b

Please sign in to comment.