-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toward confined protobuf stubs #65
Draft
dckc
wants to merge
16
commits into
ag-offer-sign
Choose a base branch
from
ag-trade-pb-es
base: ag-offer-sign
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- protobuf is a runtime dep - buf config - generate JS modules from .proto - export swingset/msgs etc.
- patch-package dep
- protobuf-es - patch-package
cosmjs expects Message.create({...}) rather than new Message({...}) etc. In particular: bytes scalar fields such as owner are Uint8Array without base64 encoding.
dckc
changed the title
confine smartWallet module
confine MsgWalletSpendAction protobuf code
Dec 3, 2023
dckc
changed the title
confine MsgWalletSpendAction protobuf code
toward confined protobuf stubs
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an analog of
@agoric-cosmic-proto
using protobuf-es:Using that, I can
end make proto-puzzle.js
fully confined:But there's lots of other stubs in
cosmjs-types
built with protobufjs where I getTypeError#1: Cannot read properties of undefined (reading 'dcodeIO')
So I couldn't config
agoricZone.js
let alonesmartWallet.js
.ref: