adjust rollup config to work with new typescript plugin version

dcastil · Oct 1, 2024 · 4881dd8 · 4881dd8
1 parent 30f6799
commit 4881dd8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/scripts/rollup.config.mjs b/scripts/rollup.config.mjs
@@ -26,15 +26,7 @@ export default defineConfig([
             }),
         ],
         external: /node_modules/,
-        plugins: [
-            del({ targets: 'dist/*' }),
-            nodeResolve(),
-            typescript({
-                compilerOptions: {
-                    noEmitOnError: true,
-                },
-            }),
-        ],
+        plugins: [del({ targets: 'dist/*' }), nodeResolve(), typescript()],
     },
 
     // es5 entry point
@@ -57,10 +49,10 @@ export default defineConfig([
             nodeResolve(),
             typescript({
                 compilerOptions: {
-                    noEmitOnError: true,
                     // We don't want to emit declaration files more than once
                     declaration: false,
                     declarationMap: false,
+                    outDir: 'dist/es5/types',
                 },
             }),
         ],

diff --git a/tsconfig.json b/tsconfig.json
@@ -13,13 +13,14 @@
         // Emit
         "declaration": true,
         "noEmit": true,
-        "outDir": "types",
+        "outDir": "dist/types",
         "sourceMap": true,
         // Interop Constraints
         "esModuleInterop": true,
         "forceConsistentCasingInFileNames": true,
         // Language and Environment
-        "target": "ESNext"
+        "target": "ESNext",
+        "noEmitOnError": true
     },
     "include": ["src/**/*"]
 }