fix rollup and source map paths

dcastil · Dec 6, 2024 · 21f8f37 · 21f8f37
1 parent 208aa83
commit 21f8f37
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/scripts/rollup.config.mjs b/scripts/rollup.config.mjs
@@ -28,7 +28,15 @@ export default defineConfig([
             }),
         ],
         external: /node_modules/,
-        plugins: [del({ targets: 'dist/*' }), nodeResolve(), typescript()],
+        plugins: [
+            del({ targets: 'dist/*' }),
+            nodeResolve(),
+            typescript({
+                compilerOptions: {
+                    outDir: path.dirname(pkg.exports['.'].import),
+                },
+            }),
+        ],
     },
 
     // es5 entry point
@@ -55,22 +63,24 @@ export default defineConfig([
                     declaration: false,
                     declarationMap: false,
                     outDir: path.dirname(pkg.exports['./es5'].import),
+                    // This is needed to correct source map paths
+                    sourceRoot: '../src',
                 },
             }),
         ],
     },
 
     // Type declarations of default and es5 entry points
     {
-        input: 'dist/types/index.d.ts',
+        input: 'dist/index.d.ts',
         output: {
             file: pkg.exports['.'].types,
             format: 'esm',
         },
         plugins: [
             dts(),
             del({
-                targets: 'dist/types',
+                targets: ['dist/lib', 'dist/index.d.ts'],
                 hook: 'buildEnd',
                 runOnce: true,
             }),
@@ -94,11 +104,6 @@ function getOutputConfig({ file, format, targets }) {
         sourcemap: true,
         freeze: false,
         generatedCode: 'es2015',
-        sourcemapPathTransform(relativeSourcePath) {
-            // This is necessary because of the tsconfig.compilerOptions.outDir option resulting in a path one level deeper than the output directory.
-            // But we also don't want to sync those output paths because that would make the setup for rollup-plugin-delete more complicated.
-            return relativeSourcePath.replace('../', '')
-        },
         plugins: [
             getBabelOutputPlugin({
                 presets: [

diff --git a/tsconfig.json b/tsconfig.json
@@ -13,7 +13,6 @@
         // Emit
         "declaration": true,
         "noEmit": true,
-        "outDir": "dist/types",
         "sourceMap": true,
         // Interop Constraints
         "esModuleInterop": true,