Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix binary layout of DSS option #12

Open
dcaratti opened this issue Jan 30, 2020 · 0 comments
Open

fix binary layout of DSS option #12

dcaratti opened this issue Jan 30, 2020 · 0 comments

Comments

@dcaratti
Copy link
Owner

the DSS option has a binary layout that does not reflect real MPTCP implementation, e.g. the offset of DSN is not correct when DACK4 is in use (and __packed doesn't really make sense in the struct definition). We should either model correctly all the DSN4/8 + DACK4/8 cases, or just use the widest case and account for shorter values when the 32-bit version is in use.
@dcaratti dcaratti mentioned this issue May 21, 2020
Closed
dcaratti added a commit that referenced this issue Aug 17, 2020
@dcaratti
Merge pull request #12 from matttbe/mptcp_common_path
82dbe73 
mptcp: fix path of 'common' dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcaratti