-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to latest, fix spec linting errors #975
Conversation
@@ -1,28 +1,68 @@ | |||
{ | |||
"browser": true, | |||
"bitwise": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, we do have bitwise operators in portions of the code. Turn this off to find them...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting. all of those look legitimate except for this one:
src/data-table.js
106 | bAllFunctions = bAllFunctions & (typeof f === 'function');
which i'll fix when i merge this for the next beta release. it's harmless, but one still shouldn't use bitwise for booleans.
then there's the annoying but apparently very fast n | 0
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://jsperf.com/floor-vs-parseint-vs-bitwise
25% faster than Math.floor, but likely negligible performance hit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, it's probably not helping anything. our bottleneck is the DOM, not math.
Not sure what your preference is on "
vs
but I corrected some of those cases. |
One last thing, I have to recommend this global npm dependency, because it works very well. https://www.npmjs.com/package/npm-check-updates At the CLI: |
Alrighty, I fixed almost all of the linter errors in |
Neat, thanks! I'm not crazy about |
…file to lint these as well.
Last update fixes the remaining issues with the spec directory and adds /spec to the jscs/jshint paths to lint. I want to point out as well, we have a script at I'd like to get this removed from the source and retrieved using npm instead. |
Can't find an npm module for that - is there a standard, safe way to pull sources from github? It seems to be used by grunt-saucelabs, which just says pull it from github. https://www.npmjs.com/package/grunt-saucelabs#test-result-details-with-jasmine |
Actually, there seem to be two copies within grunt-saucelabs itself:
|
Ya know for the life of me, I can't figure out how to install it directly from github... I for certain have done this before. I'll create a PR on that repo for a package.json and a request publish to npm... |
I think it's probably fine to use the copy from saucelabs, since that's what we're using it for. |
sounds good to me |
Updates all npm dependencies to latest. Update jscs & jshint options.