Input filter dc v3 #1387
Input filter dc v3 #1387
Conversation
|
Marking it complete from my side for now. :) My suggestion will be to choose a more appropriate name for this. Something to do with text/search/filter/widget. Will look forward for suggestions. |
src/filter-input.js
Outdated
| return s.toLowerCase(); | ||
| }; | ||
|
|
||
| var _filterFunctionFactory = function (query) { |
There was a problem hiding this comment.
The coding convention in dc.js is to use a function declaration rather than a variable, for local functions that won't be replaced. (Using a variable for _normalize makes sense because it will change.)
There was a problem hiding this comment.
Did you mean for filterFunctionFactory?
filterFunctionFactory can change in some specific cases. There is get/set for this.
There was a problem hiding this comment.
Whoops, you're so right. Sorry for the noise.
|
I agree, @tttp, any opinions? |
|
Renamed inputFilter to textFilterWidget. Ready for your review. |
Add a wordcloud Add a new input-filter graph delete cloud for now clean text, remove dead code add configuration option for throttle duration and filter work on tests+update based on input on the PR and ML remove mandatory group() that isn't used latest version
|
Rebased and changed base to dc.js/develop. |
|
Fine for the change of the name on my side, thanks @kum-deepak ! |
|
@kum-deepak this PR #1387 patched on top of dc.js/develop and worked wonderfully in my application layer. dc.textFilterWidget is a wonderful feature addition! I would love to see this become part of 3.0 release. |
|
I think this could use one or two more test cases, but I am merging it anyway for 3.0.0. If any issues or ambiguities arise, we can add test cases then. Thanks @tttp, @kum-deepak! |
Started work. Will work on making in similar in code convention as other D3 modules. I will inform when I am happy with the work.
Based on #936