Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition delay #1113

Closed
wants to merge 2 commits into from
Closed

Transition delay #1113

wants to merge 2 commits into from

Conversation

mbustosorg
Copy link
Contributor

Adding the ability to specify the transition delay in addition to transition duration. This allows you to create some more interesting transition flows by adjusting when the transitions would start.

  .transitionDelay(function (d,i) {
  return Math.floor((Math.random() * 1000) + 1);
   })

This creates a random 0-1 second delay which can give the transition another dimension.

@mbustosorg mbustosorg closed this Mar 5, 2016
@mbustosorg mbustosorg deleted the transition-delay branch March 5, 2016 00:34
@gordonwoodhull
Copy link
Contributor

Hey @mbustosorg did this not work or did you close the PR for another reason?

Looks interesting.

@mbustosorg
Copy link
Contributor Author

Hi Gordon.

I messed up the pr. I'm going to resubmit it in the next day.

Thanks for the comment. Keep an eye out!

Mauricio

On Wednesday, March 9, 2016, Gordon Woodhull [email protected]
wrote:

Hey @mbustosorg https://github.com/mbustosorg did this not work or did
you close the PR for another reason?

Looks interesting.


Reply to this email directly or view it on GitHub
#1113 (comment).

@mbustosorg
Copy link
Contributor Author

Hi Gordon,

I'm having trouble getting the tests to pass on the pull request. It's
#1116. Tests are passing on my machine but the CI run is failing. Can you
advise?

Thanks,
mauricio

On Wed, Mar 9, 2016 at 11:41 PM, Mauricio Bustos [email protected] wrote:

Hi Gordon.

I messed up the pr. I'm going to resubmit it in the next day.

Thanks for the comment. Keep an eye out!

Mauricio

On Wednesday, March 9, 2016, Gordon Woodhull [email protected]
wrote:

Hey @mbustosorg https://github.com/mbustosorg did this not work or did
you close the PR for another reason?

Looks interesting.


Reply to this email directly or view it on GitHub
#1113 (comment).

@mbustosorg
Copy link
Contributor Author

Hi Gordon,

I'm having trouble with the tests. I'm getting the specs to run fine in
the browser but am seeing:

Error caught from PhantomJS. More info can be found by opening the Spec
Runner in a browser.

This is showing up in the Travis CI test also. If I use the --force all
tests pass.

Have you seen this before?

Thanks,
mauricio

On Fri, Mar 11, 2016 at 12:29 AM, Mauricio Bustos [email protected] wrote:

Hi Gordon,

I'm having trouble getting the tests to pass on the pull request. It's
#1116. Tests are passing on my machine but the CI run is failing. Can you
advise?

Thanks,
mauricio

On Wed, Mar 9, 2016 at 11:41 PM, Mauricio Bustos [email protected] wrote:

Hi Gordon.

I messed up the pr. I'm going to resubmit it in the next day.

Thanks for the comment. Keep an eye out!

Mauricio

On Wednesday, March 9, 2016, Gordon Woodhull [email protected]
wrote:

Hey @mbustosorg https://github.com/mbustosorg did this not work or
did you close the PR for another reason?

Looks interesting.


Reply to this email directly or view it on GitHub
#1113 (comment).

@gordonwoodhull
Copy link
Contributor

Moving this discussion to the active PR #1116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants