Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box Plot: Fix keyAccessor, extent filtering, x domain change #1022

Closed
wants to merge 3 commits into from

Conversation

mtraynham
Copy link
Contributor

This fixes the data binding between the g.box SVG nodes and datum keys. It should be using the keyAccessor, but it just happens to work here because Crossfilter always has datums with a key field. There are a few other places dc does this...

This also fixes filtering with X domains that are not ordinal and use brushing. The issue can be seen in the examples page, here.

@mtraynham
Copy link
Contributor Author

Seems my own commit suffered from incorrectly accessing the datum's keys... fixed 😄

@gordonwoodhull
Copy link
Contributor

Yeah, a few places.

$ grep \\.key\\b src/* | wc
      33     204    2432

😦

Thanks, this is really helpful!

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Oct 14, 2015
@mtraynham
Copy link
Contributor Author

33 that's not so bad. Maybe a few are in comments.

…butes of the box-whiskers consistent across all data points.
@mtraynham
Copy link
Contributor Author

One more change I've added to this. If the x domain changes, the new width is only applied to the enter nodes. Older nodes retain their old width. Simple change.

@mtraynham mtraynham changed the title Box Plot: Fix keyAccessor & extent filtering Box Plot: Fix keyAccessor, extent filtering, x domain change Oct 15, 2015
@gordonwoodhull
Copy link
Contributor

Thanks @mtraynham! Merged for 2.0 beta 33.

@mtraynham mtraynham deleted the fix_box_plot branch December 4, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants