Box Plot: Fix keyAccessor, extent filtering, x domain change #1022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the data binding between the
g.box
SVG nodes and datum keys. It should be using the keyAccessor, but it just happens to work here because Crossfilter always has datums with akey
field. There are a few other placesdc
does this...This also fixes filtering with X domains that are not ordinal and use brushing. The issue can be seen in the examples page, here.