Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split dc.css #38

Closed
jeroen opened this issue Aug 21, 2012 · 2 comments
Closed

split dc.css #38

jeroen opened this issue Aug 21, 2012 · 2 comments
Assignees
Milestone

Comments

@jeroen
Copy link

jeroen commented Aug 21, 2012

Currently dc.css contains a mix of chart layout and stuff specific to the example/demo. When it is included in an application without modifying, it results in side-effects.

Would it be possible to split this into two files? One general purpose dc.css that sets nice style defaults for classes .chart, .pie-slice, etc, and which can directly be included in applications? And then another one with stuff that is specific to your demo/examples?

Also, .chart is a very general purpose term. Maybe it would be better to do .dc-chart or add two classes .dc.chart. You could automatically add these classes to the element when the chart is initiated through dc.barChart or dc.pieChart.

@NickQiZhu
Copy link
Contributor

Yeah, thats a good idea. Originally I created this css file mainly just for the example but as the library grows it is not realistic to expect user to recreate their own stylesheet from scratch. I will try to do that in 0.9 release.

@NickQiZhu
Copy link
Contributor

implemented in 0.9 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants