Skip to content

Commit

Permalink
Issue #989 - filter handler is inefficient
Browse files Browse the repository at this point in the history
  • Loading branch information
esjewett committed Aug 19, 2015
1 parent 905b7d4 commit d7ffd14
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 9 deletions.
4 changes: 2 additions & 2 deletions dc.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dc.js.map

Large diffs are not rendered by default.

7 changes: 4 additions & 3 deletions dc.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dc.min.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/base-mixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ dc.baseMixin = function (_chart) {

var _filters = [];
var _filterHandler = function (dimension, filters) {
dimension.filter(null);

if (filters.length === 0) {
dimension.filter(null);
} else if (filters.length === 1 && !Array.isArray(filters[0])) {
dimension.filterExact(filters[0]);
} else {
dimension.filterFunction(function (d) {
for (var i = 0; i < filters.length; i++) {
Expand Down

0 comments on commit d7ffd14

Please sign in to comment.