add tests for hovering external labels and paths

for #1167 but wow! the test dynamically fails to compile due to dc.transition returning a selection if duration===0
dc-js · Jul 28, 2016 · 5ad6a2b · 5ad6a2b
1 parent ee53b10
commit 5ad6a2b
Showing 1 changed file with 40 additions and 2 deletions.
diff --git a/spec/pie-chart-spec.js b/spec/pie-chart-spec.js
@@ -582,6 +582,7 @@ describe('dc.pieChart', function () {
         beforeEach(function () {
             chart = buildChart('pie-chart-external-labeling')
                 .externalLabels(10)
+                .drawPaths(true)
                 .render();
         });
         it('should place labels outside of pie offset by given radius', function () {
@@ -617,6 +618,43 @@ describe('dc.pieChart', function () {
                 expect(label.classed('external')).toBeFalsy();
             });
         });
+        it('hovering on label should highlight corresponding slice', function () {
+            chart.selectAll('#pie-chart-external-labeling text.pie-slice').each(function (d, i) {
+                var legendItem = d3.select(this);
+                legendItem.on('mouseover')(legendItem.datum(), i);
+
+                expect(chart.select('g.pie-slice._' + i).classed('highlight')).toBeTruthy();
+                legendItem.on('mouseout')(legendItem.datum());
+            });
+        });
+        it('unhovering label removes highlight from corresponding slice', function () {
+            chart.selectAll('#pie-chart-external-labeling text.pie-slice').each(function (d, i) {
+                var legendItem = d3.select(this);
+                legendItem.on('mouseover')(legendItem.datum(), i);
+                legendItem.on('mouseout')(legendItem.datum(), i);
+
+                expect(chart.select('.pie-slice._' + i).classed('highlight')).toBeFalsy();
+            });
+        });
+
+        it('hovering on path should highlight corresponding slice', function () {
+            chart.selectAll('#pie-chart-external-labeling polyline.pie-path').each(function (d, i) {
+                var legendItem = d3.select(this);
+                legendItem.on('mouseover')(legendItem.datum(), i);
+
+                expect(chart.select('g.pie-slice._' + i).classed('highlight')).toBeTruthy();
+                legendItem.on('mouseout')(legendItem.datum());
+            });
+        });
+        it('unhovering label removes highlight from corresponding slice', function () {
+            chart.selectAll('#pie-chart-external-labeling polyline.pie-path').each(function (d, i) {
+                var legendItem = d3.select(this);
+                legendItem.on('mouseover')(legendItem.datum(), i);
+                legendItem.on('mouseout')(legendItem.datum(), i);
+
+                expect(chart.select('.pie-slice._' + i).classed('highlight')).toBeFalsy();
+            });
+        });
     });
 
     describe('legends', function () {
@@ -647,7 +685,7 @@ describe('dc.pieChart', function () {
                 var legendItem = d3.select(this);
                 legendItem.on('mouseover')(legendItem.datum());
 
-                expect(chart.select('.pie-slice._' + i).classed('highlight')).toBeTruthy();
+                expect(chart.select('g.pie-slice._' + i).classed('highlight')).toBeTruthy();
                 legendItem.on('mouseout')(legendItem.datum());
             });
         });
@@ -657,7 +695,7 @@ describe('dc.pieChart', function () {
                 legendItem.on('mouseover')(legendItem.datum());
                 legendItem.on('mouseout')(legendItem.datum());
 
-                expect(chart.select('.pie-slice._' + i).classed('highlight')).toBeFalsy();
+                expect(chart.select('g.pie-slice._' + i).classed('highlight')).toBeFalsy();
             });
         });
         it('clicking on items filters them', function () {