-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower MSRV via workspace configuration #1201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! It would have been better if the change to worspace was done in a separate commit first but it's not a biggie but please address the only comment.
d76b907
to
a7fdbd3
Compare
In terms of features used in the codebase, 1.77 is the lowest we require.
a7fdbd3
to
2abe26d
Compare
@zeenix Split into two commits and removed unnecessary formatting changes. |
Awesome, thanks for going the extra mile on this. 👍 I wish all contributors were like you. |
Thanks for accepting the change! :) |
@thomaseizinger btw, please next time add the emoji itself rather than their codes. Github shows them as emojis so I didn't notice until I checked the local |
@zeenix Sorry to bother you again but can you release a new version of zbus_names ? It didn't get the memo about the new msrv https://crates.io/crates/zbus_names/versions |
This comment was marked as duplicate.
This comment was marked as duplicate.
yeah, sorry I forgot. 🤦 I'll roll it out today.. |
zbus_names 4.1.1 is now out. |
Lowers the MSRV of all packages to 1.77 as per #1107 (comment). I decided to introduce it as a workspace variable to reduce the duplication across the packages.