⏪️ Revert "Merge pull request #989 from elmarco/address" #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
force-pushed
the
revert-address-changes
branch
2 times, most recently
from
e301fc5 to
042e4e2
Compare
zeenix
force-pushed
the
revert-address-changes
branch
from
042e4e2 to
795e003
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fc03642, reversing changes made to deffbb8.
It turns out there was a major design flaw in the API: the parsed address string was not kept in a parsed state, resulting in reparsing of the string form, for each getter. Because of this, I decided to revert the changes for 5.0.