Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad formatting of accepted mechanisms, regression #1216

Closed
elmarco opened this issue Jan 13, 2025 · 3 comments · Fixed by #1237
Closed

Bad formatting of accepted mechanisms, regression #1216

elmarco opened this issue Jan 13, 2025 · 3 comments · Fixed by #1237

Comments

@elmarco
Copy link
Contributor

elmarco commented Jan 13, 2025

This is a regression from commit b792340 "zb: Use string type for auth mechanisms in Rejected cmd". The mechanisms are not parsed anymore, and they are joined without separator when returning an Handshake error, ex from gio connection:

zbus(Handshake("EXTERNAL rejected by the server. Accepted mechanisms: [EXTERNALDBUS_COOKIE_SHA1]")

@zeenix
Copy link
Contributor

zeenix commented Jan 30, 2025

he mechanisms are not parsed anymore, and they are joined without separator when returning an Handshake error, ex from gio connection:

There is nothing to parse or join. We now only support one mechanism at a time, either EXTERNAL or ANONYMOUS. See here.

@zeenix zeenix closed this as completed Jan 30, 2025
@elmarco
Copy link
Contributor Author

elmarco commented Jan 31, 2025

I undersand, yet the error produced is badly formatted.

@zeenix
Copy link
Contributor

zeenix commented Jan 31, 2025

Ah, I see. I got confused reading the description.

@zeenix zeenix reopened this Jan 31, 2025
zeenix added a commit to zeenix/zbus that referenced this issue Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants