Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use MD5 hashing to avoid long index names #386

Merged
merged 1 commit into from
May 17, 2023
Merged

use MD5 hashing to avoid long index names #386

merged 1 commit into from
May 17, 2023

Conversation

sdebruyn
Copy link
Member

resolves #317

@sdebruyn sdebruyn merged commit 6bf3c1f into master May 17, 2023
@sdebruyn sdebruyn deleted the indexes-md5 branch May 17, 2023 20:41
@sdebruyn sdebruyn added this to the v1.4.1 milestone May 21, 2023
@NicolasPA
Copy link

This index naming change is a breaking change which causes errors on our DBT models that create clustered index:
Cannot create more than one clustered index on table *. Drop the existing clustered index * before creating another. (1902)

Additionally, this would silently create duplicated indexes for non-clustered indexes because they can be more than one.

The easy is workaround is to full-refresh the DBT models, but it may be computationally costly.
The laborious but computationally efficient workaround is to manually rename all the indexes according to the new naming scheme.

Maybe it could be marked as a breaking-change in the v1.4.1 release note to help users who will get the errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_nonclustered_index macro does not check for index name length
2 participants