Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

credit where due #355

Merged
merged 3 commits into from
May 13, 2023
Merged

credit where due #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d87fb8f
credit where due
dataders May 12, 2023
47ca918
escape username string bc it has `@` symbol
dataders May 12, 2023
b7e520b
Merge branch 'master' into testtesttest
sdebruyn May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
* Replace deprecated exception functions
* Consolidate timestamp macros


Thanks [@i-j](https://github.com/l-j)!
### v1.3.0

#### Features
Expand Down
4 changes: 2 additions & 2 deletions tests/functional/adapter/test_provision_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@
select *
from sys.database_principals
where name = '{{ env_var('DBT_TEST_AAD_PRINCIPAL_1') }}')
drop user {{ env_var('DBT_TEST_AAD_PRINCIPAL_1') }}
drop user [{{ env_var('DBT_TEST_AAD_PRINCIPAL_1') }}]
sdebruyn marked this conversation as resolved.
Show resolved Hide resolved

if exists(
select *
from sys.database_principals
where name = '{{ env_var('DBT_TEST_AAD_PRINCIPAL_2') }}')
drop user {{ env_var('DBT_TEST_AAD_PRINCIPAL_2') }}
drop user [{{ env_var('DBT_TEST_AAD_PRINCIPAL_2') }}]

{%- endcall -%}
{% endmacro %}
Expand Down