Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pre-commit #353

Merged
merged 2 commits into from
May 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dbt/adapters/sqlserver/sql_server_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ def get_rows_different_sql(
column_names: Optional[List[str]] = None,
except_operator: str = "EXCEPT",
) -> str:

"""
note: using is not supported on Synapse so COLUMNS_EQUAL_SQL is adjsuted
Generate SQL for a query that returns a single row with a two
Expand Down
3 changes: 0 additions & 3 deletions dbt/adapters/sqlserver/sql_server_connection_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ def exception_handler(self, sql):

@classmethod
def open(cls, connection: Connection) -> Connection:

if connection.state == ConnectionState.OPEN:
logger.debug("Connection is already open, skipping open.")
return connection
Expand All @@ -276,7 +275,6 @@ def open(cls, connection: Connection) -> Connection:
con_str = [f"DRIVER={{{credentials.driver}}}"]

if "\\" in credentials.host:

# If there is a backslash \ in the host name, the host is a
# SQL Server named instance. In this case then port number has to be omitted.
con_str.append(f"SERVER={credentials.host}")
Expand Down Expand Up @@ -374,7 +372,6 @@ def add_query(
bindings: Optional[Any] = None,
abridge_sql_log: bool = False,
) -> Tuple[Connection, Any]:

connection = self.get_thread_connection()

if auto_begin and connection.transaction_open is False:
Expand Down
2 changes: 1 addition & 1 deletion dbt/include/sqlserver/macros/utils/timestamps.sql
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
{% macro sqlserver__snapshot_string_as_time(timestamp) -%}
{%- set result = "CONVERT(DATETIME2, '" ~ timestamp ~ "')" -%}
{{ return(result) }}
{%- endmacro %}
{%- endmacro %}
2 changes: 1 addition & 1 deletion dev_requirements.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
pytest==7.1.3
twine==4.0.2
wheel==0.40.0
pre-commit==3.2.0
pre-commit==3.3.1
pytest-dotenv==0.5.2
dbt-tests-adapter~=1.4.5
-e .