Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add relative path snippet #6547

Merged
merged 15 commits into from
Nov 27, 2024
Merged

add relative path snippet #6547

merged 15 commits into from
Nov 27, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Nov 26, 2024

@mirnawong1 mirnawong1 requested a review from a team as a code owner November 26, 2024 16:27
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 27, 2024 4:43pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Nov 26, 2024
import RelativePath from '/snippets/_relative-path.md';

<RelativePath
path="analysis-paths"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these not work in the code examples? Is there something we can do to make them generic to include them in the snippet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately they dont seem to work w props. i spent longer than i should yesterday trying to get it to work and found it just easier to hardcode it. i think it could be generic but i found that it's better to be explicit with examples so users avoid having to guess or interpret.

@mirnawong1 mirnawong1 merged commit 96df61e into current Nov 27, 2024
9 checks passed
@mirnawong1 mirnawong1 deleted the add-relative-path-callout branch November 27, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encourage relative paths (not absolute paths) in <resource>-paths project configs
2 participants